[Fixup] Fix Header Paths of oplus mtk Power Drivers#1
Open
techyminati wants to merge 1 commit intoOnePlusOSS:oneplus/MT6893_R_11.0from
Open
[Fixup] Fix Header Paths of oplus mtk Power Drivers#1techyminati wants to merge 1 commit intoOnePlusOSS:oneplus/MT6893_R_11.0from
techyminati wants to merge 1 commit intoOnePlusOSS:oneplus/MT6893_R_11.0from
Conversation
* The kernel path for mtk power drivers should be ../drivers/misc/mediatek/ , but for some reasons, the path here is ../../../../kernel-4.14/drivers/misc/mediatek/ , this is probably due to oplus's build system , it works fine in their enviroment, but for third party developer it throws error, this error is common seen in realme-kernel-oss kernels too, so lets just define its correct path Test: Error is fixed & kernel code compiles successfully. Change-Id: If9a2919b96fddc6892da50a5ed62bc8ed63971d7 Signed-off-by: techyminati <sinha.aryan03@gmail.com>
|
Looks good |
|
Looks fine |
|
Built just now and it seems to be building fine, gg. |
|
Noice!! |
|
looks nice |
|
Thank you! |
|
"OnePlus" years later. This is still / also a problem in the new kernel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it works fine in their enviroment, but for third party developer it throws error, , so lets just define its correct path & fix the error
Test: Error is fixed & kernel code compiles successfully.